[jira] [Created] (STORM-1412) Null check should be done in the first place

[Xin Wang (JIRA)]

Xin Wang created STORM-1412:
-------------------------------

             Summary: Null check should be done in the first place
                 Key: STORM-1412
                 URL: https://issues.apache.org/jira/browse/STORM-1412
             Project: Apache Storm
          Issue Type: Bug
          Components: storm-core
            Reporter: Xin Wang
            Assignee: Xin Wang


Null check should be done in the first place for class User, otherwise we may 
get a NPE.
before fix:
{code}
     private void moveTopology(TopologyDetails topo, Set<TopologyDetails> src, 
String srcName, Set<TopologyDetails> dest, String destName) {
-        LOG.debug("For User {} Moving topo {} from {} to {}", this.userId, 
topo.getName(), srcName, destName);
         if (topo == null) {
             return;
         }
{code}

after fix:
{code}
    private void moveTopology(TopologyDetails topo, Set<TopologyDetails> src, 
String srcName, Set<TopologyDetails> dest, String destName) {
        if (topo == null) {
            return;
        }

        LOG.debug("For User {} Moving topo {} from {} to {}", this.userId, 
topo.getName(), srcName, destName);

{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)