Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/977#discussion_r48927497 --- Diff: external/storm-solr/src/main/java/org/apache/storm/solr/bolt/SolrUpdateBolt.java --- @@ -92,11 +94,19 @@ private void ack(Tuple tuple) throws SolrServerException, IOException { if (commitStgy == null) { collector.ack(tuple); } else { - toCommitTuples.add(tuple); - commitStgy.update(); - if (commitStgy.commit()) { + if (TupleUtils.isTick(tuple)) { + LOG.debug("TICK! forcing solr client commit"); + collector.ack(tuple); --- End diff -- Tick tuples are not generated from a spout but inserted periodically into the executor receive-queue. Since tick-tuples are not tracked by the acker, I dont think it needs to be acked. Acking it does not cause any harm but unnecessary. Correct me if I am overlooking something.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---