Github user hmcl commented on a diff in the pull request:

    https://github.com/apache/storm/pull/977#discussion_r49161066
  
    --- Diff: 
external/storm-solr/src/main/java/org/apache/storm/solr/config/SolrConfig.java 
---
    @@ -39,4 +40,13 @@ public SolrConfig(String zkHostString) {
         public String getZkHostString() {
             return zkHostString;
         }
    +
    +    public int getTickTupleInterval() {
    +        return tickTupleInterval;
    +    }
    +
    +    public void setTickTupleInterval(int tickTupleInterval) {
    --- End diff --
    
    @vesense Can you please delete this set method and pass the 
tickTupleInterval in the constructor, or use a builder pattern. This object 
should be immutable and fully initialized once passed to the Bolt.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to