Github user satishd commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1001#discussion_r49260989
  
    --- Diff: bin/storm.py ---
    @@ -229,7 +231,7 @@ def jar(jarfile, klass, *args):
             daemon=False,
             jvmopts=JAR_JVM_OPTS + ["-Dstorm.jar=" + jarfile])
     
    -def sql(sql_file, topo_nam):
    --- End diff --
    
    minor nit: You may want to rename topo_name to topology_name. We can have 
JIRA to add a test which uses storm sql command.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to