[
https://issues.apache.org/jira/browse/STORM-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103008#comment-15103008
]
ASF GitHub Bot commented on STORM-1478:
---------------------------------------
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1020
[STORM-1478] make bolt's getComponentConfiguration method cleaner/simpler
This PR follow
https://github.com/apache/storm/pull/977#discussion_r49160913 @hmcl 's comment:
>I noticed that the body of this method is exactly the same for
AbstractHdfsBolt. Furthermore, it's very likely that many Storm connector bolts
will use the same code. Can you please write a helper method in TupleUtils and
call that method here and AbstractHdfsBolt.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-1478
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1020.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1020
----
commit 40df09547e4e8bf6c80cea4f1250fa27243646b8
Author: Xin Wang <best.wang...@163.com>
Date: 2016-01-16T05:44:32Z
make getComponentConfiguration cleaner
----
> make bolt's getComponentConfiguration method cleaner/simpler
> ------------------------------------------------------------
>
> Key: STORM-1478
> URL: https://issues.apache.org/jira/browse/STORM-1478
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-hdfs, storm-hive
> Reporter: Xin Wang
> Assignee: Xin Wang
> Priority: Minor
>
> https://github.com/apache/storm/pull/977#discussion_r49160913
> This jira follow hmcl's comment:
> {quote}
> I noticed that the body of this method is exactly the same for
> AbstractHdfsBolt. Furthermore, it's very likely that many Storm connector
> bolts will use the same code. Can you please write a helper method in
> TupleUtils and call that method here and AbstractHdfsBolt.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
