[ 
https://issues.apache.org/jira/browse/STORM-1449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107372#comment-15107372
 ] 

ASF GitHub Bot commented on STORM-1449:
---------------------------------------

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/994#issuecomment-172976476
  
    @priyank5485 you are correct.  I didn't look into this in great detail 
until now.  What is more if you submit using an old client you will get 
deserialization errors too, because the SerialId is not set.
    
    STORM-1220 seems to fundamentally not be able to maintain that backwards 
compatibility.  So now the question is are the benefits of STORM-1220 worth the 
incompatibility?  To me it seems likely that they are, because it is just 
updating a dependency.


> Fix Kafka spout to maintain backward compatibility to pass byte[] instead of 
> ByteBuffer
> ---------------------------------------------------------------------------------------
>
>                 Key: STORM-1449
>                 URL: https://issues.apache.org/jira/browse/STORM-1449
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>             Fix For: 1.0.0
>
>
> STORM-1220 introduced some changes where in one place it passes ByteBuffer as 
> is instead of byte[]. Existing bolts that expects a byte[] fails due to this 
> with "java.lang.RuntimeException: java.lang.ClassCastException: 
> java.nio.HeapByteBuffer cannot be cast to [B "



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to