[
https://issues.apache.org/jira/browse/STORM-733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111881#comment-15111881
]
ASF GitHub Bot commented on STORM-733:
--------------------------------------
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/489#issuecomment-173798895
Seems like issue is not valid cause we replace
IOUtils.toString(processErrorStream) with processErrorStream.available().
Maybe it was handled from another pull request.
Then for me this PR just refactors duplicate codes.
I think it is still fine, but not mandatory. And it should be treated to
other issue since this issue is no longer valid.
> ShellBolts that don't respond to heartbeats are not being killed
> ----------------------------------------------------------------
>
> Key: STORM-733
> URL: https://issues.apache.org/jira/browse/STORM-733
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-multilang
> Affects Versions: 0.9.3
> Reporter: Re'em Bensimhon
> Assignee: Re'em Bensimhon
> Priority: Critical
>
> In cases where a multilang bolt is stuck (say, an infinite loop), the
> heartbeats are supposed to detect the issue and kill the supervisor process.
> In 0.9.3 this doesn't happen due to
> backtype.storm.utils.ShellProcess.getErrorsString() call in ShellBolt.die()
> This call, which in turn executes IOUtils.toString(processErrorStream) will
> block the thread until process exits. Heartbeat flow should not assume
> process had exited.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
