[ https://issues.apache.org/jira/browse/STORM-1257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117418#comment-15117418 ]
ASF GitHub Bot commented on STORM-1257: --------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1047#discussion_r50851943 --- Diff: storm-core/src/jvm/org/apache/storm/zookeeper/LeaderElectorImp.java --- @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.zookeeper; + +import org.apache.curator.framework.CuratorFramework; +import org.apache.curator.framework.recipes.leader.LeaderLatch; +import org.apache.curator.framework.recipes.leader.LeaderLatchListener; +import org.apache.curator.framework.recipes.leader.Participant; +import org.apache.storm.nimbus.ILeaderElector; +import org.apache.storm.nimbus.NimbusInfo; +import org.apache.storm.utils.Utils; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.concurrent.atomic.AtomicReference; + + +public class LeaderElectorImp implements ILeaderElector { + private static Logger LOG = LoggerFactory.getLogger(LeaderElectorImp.class); + private Map conf; + private List<String> servers; + private CuratorFramework zk; + private String leaderlockPath; + private String id; + private AtomicReference<LeaderLatch> leaderLatch; + private AtomicReference<LeaderLatchListener> leaderLatchListener; --- End diff -- Can we please mark all of these member variables as final? None of them are ever supposed to change and it would have caught the leaderlockPath not being set. > port backtype.storm.zookeeper to java > ------------------------------------- > > Key: STORM-1257 > URL: https://issues.apache.org/jira/browse/STORM-1257 > Project: Apache Storm > Issue Type: New Feature > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: John Fang > Labels: java-migration, jstorm-merger > > A wrapper around zookeeper/curator. -- This message was sent by Atlassian JIRA (v6.3.4#6332)