[
https://issues.apache.org/jira/browse/STORM-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117584#comment-15117584
]
ASF GitHub Bot commented on STORM-1501:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1046#discussion_r50867596
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -553,7 +553,8 @@
(catch InterruptedException e
(log-message log-prefix " interrupted.")))
(exit-code-callback (.exitValue process)))
- nil)))
+ nil)
+ :kill-fn (fn [error] (log-error (RuntimeException. ("launch
process failed..."))))))
--- End diff --
Why are we throwing away error?
What happens if this does not exit? I assume that the heartbeat monitoring
will detect it and do the right thing, but are there other places in the code
besides a worker process that we use this? Will there be problems especially
around the exit-code-callback if they are not called?
> launch worker process exception will cause supervisor process exited
> ---------------------------------------------------------------------
>
> Key: STORM-1501
> URL: https://issues.apache.org/jira/browse/STORM-1501
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Affects Versions: 2.0.0
> Reporter: caofangkun
> Assignee: caofangkun
> Priority: Trivial
>
> [util.clj/async-loop |
> https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L474]
> default kill-fn will kill current process
> when supervisor use [util.clj/launch-process |
> https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/util.clj#L546]
> to launch worker process , if exeception occurs , supervisor process will
> exit.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
