Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1043#discussion_r50894044
  
    --- Diff: storm-core/src/clj/org/apache/storm/converter.clj ---
    @@ -201,17 +231,28 @@
           (.get_owner storm-base)
           (clojurify-topology-action-options (.get_topology_action_options 
storm-base))
           (convert-to-symbol-from-status (.get_prev_status storm-base))
    +;      (Utils/mapVal
    +;        (reify IFn (eval [this x] (clojurify-debugoptions x)))
    +;        (.get_component_debug storm-base)))))
           (map-val clojurify-debugoptions (.get_component_debug storm-base)))))
     
    +;TODO: when translating this function, you should replace the map-val with 
a proper for loop HERE
    +;TODO: when translating this function, you should replace the map-val with 
a proper for loop HERE
     (defn thriftify-stats [stats]
       (if stats
    +;    (Utils/mapVal
    +;      (reify IFn (eval [this x] (thriftify-executor-stats x)))
         (map-val thriftify-executor-stats
           (map-key #(ExecutorInfo. (int (first %1)) (int (last %1)))
             stats))
         {}))
     
    +;TODO: when translating this function, you should replace the map-val with 
a proper for loop HERE
    +;TODO: when translating this function, you should replace the map-val with 
a proper for loop HERE
     (defn clojurify-stats [stats]
       (if stats
    +;    (Utils/mapVal
    +;      (reify IFn (eval [this x] (clojurify-executor-stats x)))
    --- End diff --
    
    and delete these too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to