Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1043#discussion_r50896559 --- Diff: storm-core/src/jvm/org/apache/storm/utils/Time.java --- @@ -102,6 +102,14 @@ public static long currentTimeMillis() { public static int currentTimeSecs() { return (int) (currentTimeMillis() / 1000); } + + public static int delta(int timeInSeconds) { + return Time.currentTimeSecs() - timeInSeconds; + } + + public static long deltaMs(long timeInMilliseconds) { --- End diff -- I am conflicted about this. The function feels like it should be a part of time, but Time provides APIs that can simulate time, but this function does not. At a minimum can we add some javadocs explaining this?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---