Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1047#discussion_r50990747
  
    --- Diff: storm-core/test/clj/org/apache/storm/cluster_test.clj ---
    @@ -308,11 +309,11 @@
     
     (deftest test-cluster-state-default-acls
       (testing "The default ACLs are empty."
    -    (stubbing [zk/mkdirs nil
    +    (stubbing [Zookeeper/mkdirs nil
    --- End diff --
    
    You cannot stub a java static function.  It only works on clojure 
functions.  Please take a look at how we did this in #1030 and #1043.  It is 
not the cleanest thing, but it does work until we can move to an architecture 
that is much more java like.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to