[
https://issues.apache.org/jira/browse/STORM-1505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120024#comment-15120024
]
ASF GitHub Bot commented on STORM-1505:
---------------------------------------
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/1050#discussion_r51036546
--- Diff:
storm-core/src/jvm/org/apache/storm/trident/planner/processor/MapProcessor.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.trident.planner.processor;
+
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.trident.operation.FlatMapFunction;
+import org.apache.storm.trident.operation.Function;
+import org.apache.storm.trident.operation.MapFunction;
+import org.apache.storm.trident.operation.TridentOperationContext;
+import org.apache.storm.trident.planner.ProcessorContext;
+import org.apache.storm.trident.planner.TridentProcessor;
+import org.apache.storm.trident.tuple.TridentTuple;
+import org.apache.storm.trident.tuple.TridentTupleView;
+import org.apache.storm.tuple.Fields;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * Processor for executing {@link
org.apache.storm.trident.Stream#map(MapFunction)} and
+ * {@link org.apache.storm.trident.Stream#flatMap(FlatMapFunction)}
functions.
+ */
+public class MapProcessor implements TridentProcessor {
+ Function _function;
+ TridentContext _context;
+ FreshCollector _collector;
+ Fields _inputFields;
+ TridentTupleView.ProjectionFactory _projection;
+
+ public MapProcessor(Fields inputFields, Function function) {
+ _function = function;
+ _inputFields = inputFields;
+ }
+
+ @Override
+ public void prepare(Map conf, TopologyContext context, TridentContext
tridentContext) {
+ List<TridentTuple.Factory> parents =
tridentContext.getParentTupleFactories();
+ if(parents.size()!=1) {
+ throw new RuntimeException("Each operation can only have one
parent");
--- End diff --
Should this be "Map operation can have only one parent"?
> Add map and flatMap operations in trident api
> ---------------------------------------------
>
> Key: STORM-1505
> URL: https://issues.apache.org/jira/browse/STORM-1505
> Project: Apache Storm
> Issue Type: Improvement
> Reporter: Arun Mahadevan
> Assignee: Arun Mahadevan
>
> map and flatMap are common stream operations.
> Right now in trident this has to be implemented via each() which also sends
> the input field values in addition to the mapped field values, so the map and
> flatmap should make things slightly more efficient and easy.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
