Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1053#discussion_r51139248 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java --- @@ -0,0 +1,174 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.container.cgroup; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.BufferedReader; +import java.io.BufferedWriter; +import java.io.File; +import java.io.FileReader; +import java.io.FileWriter; +import java.io.IOException; +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +public class CgroupUtils { + + public static final Logger LOG = LoggerFactory.getLogger(CgroupUtils.class); + + public static void deleteDir(String dir) { + try { + String cmd = "rmdir " + dir; + SystemOperation.exec(cmd); --- End diff -- I know that this came from JStorm, but is there a reason we should not just do ``` File d = new File(dir); if (d.exists()) { if (d.isDirectory()) { d.delete(); //TODO need to check results } else { throw some error; } } ``` The current code is not safe, it opens up the potential for command injection.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---