Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1056#discussion_r51264908 --- Diff: external/storm-kafka/src/jvm/storm/kafka/KafkaSpout.java --- @@ -78,9 +82,11 @@ public void open(Map conf, final TopologyContext context, final SpoutOutputColle if (zkPort == null) { zkPort = ((Number) conf.get(Config.STORM_ZOOKEEPER_PORT)).intValue(); } + if (zkServers == null) throw new IllegalStateException("zkServers is null"); stateConf.put(Config.TRANSACTIONAL_ZOOKEEPER_SERVERS, zkServers); + if (zkPort == null) throw new IllegalStateException("zkPort is null"); stateConf.put(Config.TRANSACTIONAL_ZOOKEEPER_PORT, zkPort); - stateConf.put(Config.TRANSACTIONAL_ZOOKEEPER_ROOT, _spoutConfig.zkRoot); --- End diff -- Why do we want to drop the transactional root?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---