Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1055#discussion_r51269024 --- Diff: storm-core/src/jvm/org/apache/storm/Thrift.java --- @@ -0,0 +1,343 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm; + +import org.apache.storm.generated.Bolt; +import org.apache.storm.generated.JavaObjectArg; +import org.apache.storm.generated.SpoutSpec; +import org.apache.storm.generated.StateSpoutSpec; +import org.apache.storm.generated.StreamInfo; + +import java.lang.reflect.Constructor; +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.List; +import java.util.HashMap; +import java.io.Serializable; +import java.util.Map; +import java.util.Map.Entry; +import java.util.Set; + +import org.apache.storm.generated.JavaObject; +import org.apache.storm.generated.Grouping; +import org.apache.storm.generated.StormTopology; +import org.apache.storm.generated.StormTopology._Fields; +import org.apache.storm.generated.ComponentCommon; +import org.apache.storm.generated.NullStruct; +import org.apache.storm.generated.GlobalStreamId; +import org.apache.storm.generated.ComponentObject; + +import org.apache.storm.task.IBolt; +import org.apache.storm.topology.BoltDeclarer; +import org.apache.storm.topology.IRichBolt; +import org.apache.storm.topology.IBasicBolt; +import org.apache.storm.topology.IRichSpout; +import org.apache.storm.topology.SpoutDeclarer; +import org.json.simple.JSONValue; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.storm.utils.Utils; +import org.apache.storm.grouping.CustomStreamGrouping; +import org.apache.storm.topology.TopologyBuilder; + +public class Thrift { + private static Logger LOG = LoggerFactory.getLogger(Thrift.class); + + public static StormTopology._Fields[] STORM_TOPOLOGY_FIELDS = null; + public static StormTopology._Fields[] SPOUT_FIELDS = --- End diff -- Could you please file a follow on JIRA for us to make STORM_TOPOLOGY_FIELDS and SPOUT_FIELDS private? I don't think it is very clean to expose them this way. I would rather provide high level APIs or migrate the functions that need these into this class.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---