Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1069#discussion_r51699466
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1374,5 +1374,61 @@ public static RuntimeException
wrapInRuntime(Exception e){
return new RuntimeException(e);
}
}
+
+ public static <T> long bitXorValsSets(java.util.Set<T> vals) {
+ long rtn = 0l;
+ for (T n : vals) {
+ rtn = bitXor(rtn, n);
+ }
+ return rtn;
+ }
+
+ public static long bitXor(Object a, Object b) {
--- End diff --
given that bixXor falls in critical path, is it possible to avoid
instanceof checks. why is there special treatment for Set type?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
