[
https://issues.apache.org/jira/browse/STORM-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130717#comment-15130717
]
ASF GitHub Bot commented on STORM-1273:
---------------------------------------
Github user knusbaum commented on a diff in the pull request:
https://github.com/apache/storm/pull/1071#discussion_r51755050
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -275,11 +274,11 @@
(defn do-rebalance [nimbus storm-id status storm-base]
(let [rebalance-options (:topology-action-options storm-base)]
- (.update-storm! (:storm-cluster-state nimbus)
+ (.updateStorm (:storm-cluster-state nimbus)
storm-id
- (-> {:topology-action-options nil}
+ (thriftify-storm-base (-> {:topology-action-options nil}
(assoc-non-nil :component->executors (:component->executors
rebalance-options))
- (assoc-non-nil :num-workers (:num-workers rebalance-options)))))
+ (assoc-non-nil :num-workers (:num-workers rebalance-options))))))
--- End diff --
Can we put `thriftify-storm-base` at the end of the `->` to follow suit
here?
> port backtype.storm.cluster to java
> -----------------------------------
>
> Key: STORM-1273
> URL: https://issues.apache.org/jira/browse/STORM-1273
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> current state of the cluster (Some of this moves to java as a part of
> heartbeat server)
> https://github.com/apache/storm/tree/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster
> as an example
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
