Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1075#issuecomment-179953694
Overall things look good. A few comments about configuration. The only
real thing that is missing for me is Documentation. At least javadocs on how
to use this and comment in defaults.yaml would be good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
