Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1080#discussion_r51981153
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -58,7 +58,7 @@
(.prepare grouping context (GlobalStreamId. component-id stream-id)
target-tasks)
(if (instance? LoadAwareCustomStreamGrouping grouping)
(fn [task-id ^List values load]
- (.chooseTasks grouping task-id values load))
+ (.chooseTasks ^LoadAwareCustomStreamGrouping grouping task-id values
load))
--- End diff --
can you also give the type hint for target-tasks as List? I suspect there
is no reflection warning for that, because no method is being invoked on
target-tasks. but it is better to follow the practice nonetheless for
safeguarding.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
