Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52069255
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -0,0 +1,43 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.container;
+
+import java.util.Map;
+
+/**
+ * A plugin to support resource isolation and limitation within Storm
+ */
+public interface ResourceIsolationInterface {
+
+ /**
+ * @param workerId worker id of the worker to start
+ * @param resources set of resources to limit
+ * @return a String that includes to command on how to start the
worker. The string returned from this function
+ * will be concatenated to the front of the command to launch
logwriter/worker in supervisor.clj
+ */
+ public String startNewWorker(String workerId, Map resources);
--- End diff --
minor: these method declarations do not need `public`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
