Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52097950
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupCommon.java ---
@@ -0,0 +1,226 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup;
+
+import org.apache.storm.container.cgroup.core.CgroupCore;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+
+public class CgroupCommon implements CgroupCommonOperation {
+
+ public static final String TASKS = "/tasks";
+ public static final String NOTIFY_ON_RELEASE = "/notify_on_release";
+ public static final String RELEASE_AGENT = "/release_agent";
+ public static final String CGROUP_CLONE_CHILDREN =
"/cgroup.clone_children";
+ public static final String CGROUP_EVENT_CONTROL =
"/cgroup.event_control";
+ public static final String CGROUP_PROCS = "/cgroup.procs";
+
+ private final Hierarchy hierarchy;
+
+ private final String name;
+
+ private final String dir;
+
+ private final CgroupCommon parent;
+
+ private final Map<SubSystemType, CgroupCore> cores;
+
+ private final boolean isRoot;
+
+ private final Set<CgroupCommon> children = new HashSet<CgroupCommon>();
+
+ private static final Logger LOG =
LoggerFactory.getLogger(CgroupCommon.class);
+
+ public CgroupCommon(String name, Hierarchy hierarchy, CgroupCommon
parent) {
+ this.name = parent.getName() + "/" + name;
+ this.hierarchy = hierarchy;
+ this.parent = parent;
+ this.dir = parent.getDir() + "/" + name;
+ this.init();
+ cores =
CgroupCoreFactory.getInstance(this.hierarchy.getSubSystems(), this.dir);
+ this.isRoot = false;
+ }
+
+ /**
+ * rootCgroup
+ */
+ public CgroupCommon(Hierarchy hierarchy, String dir) {
+ this.name = "";
+ this.hierarchy = hierarchy;
+ this.parent = null;
+ this.dir = dir;
+ this.init();
+ cores =
CgroupCoreFactory.getInstance(this.hierarchy.getSubSystems(), this.dir);
+ this.isRoot = true;
+ }
+
+ @Override
+ public void addTask(int taskId) throws IOException {
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir, TASKS),
String.valueOf(taskId));
+ }
+
+ @Override
+ public Set<Integer> getTasks() throws IOException {
+ List<String> stringTasks =
CgroupUtils.readFileByLine(Constants.getDir(this.dir, TASKS));
+ Set<Integer> tasks = new HashSet<Integer>();
+ for (String task : stringTasks) {
+ tasks.add(Integer.valueOf(task));
+ }
+ return tasks;
+ }
+
+ @Override
+ public void addProcs(int pid) throws IOException {
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir,
CGROUP_PROCS), String.valueOf(pid));
+ }
+
+ @Override
+ public Set<Integer> getPids() throws IOException {
+ List<String> stringPids =
CgroupUtils.readFileByLine(Constants.getDir(this.dir, CGROUP_PROCS));
+ Set<Integer> pids = new HashSet<Integer>();
+ for (String task : stringPids) {
+ pids.add(Integer.valueOf(task));
+ }
+ return pids;
+ }
+
+ @Override
+ public void setNotifyOnRelease(boolean flag) throws IOException {
+
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir,
NOTIFY_ON_RELEASE), flag ? "1" : "0");
+ }
+
+ @Override
+ public boolean getNotifyOnRelease() throws IOException {
+ return CgroupUtils.readFileByLine(Constants.getDir(this.dir,
NOTIFY_ON_RELEASE)).get(0).equals("1") ? true : false;
+ }
+
+ @Override
+ public void setReleaseAgent(String command) throws IOException {
+ if (!this.isRoot) {
+ return;
+ }
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir,
RELEASE_AGENT), command);
+ }
+
+ @Override
+ public String getReleaseAgent() throws IOException {
+ if (!this.isRoot) {
+ return null;
+ }
+ return CgroupUtils.readFileByLine(Constants.getDir(this.dir,
RELEASE_AGENT)).get(0);
+ }
+
+ @Override
+ public void setCgroupCloneChildren(boolean flag) throws IOException {
+ if (!this.cores.keySet().contains(SubSystemType.cpuset)) {
+ return;
+ }
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir,
CGROUP_CLONE_CHILDREN), flag ? "1" : "0");
+ }
+
+ @Override
+ public boolean getCgroupCloneChildren() throws IOException {
+ return CgroupUtils.readFileByLine(Constants.getDir(this.dir,
CGROUP_CLONE_CHILDREN)).get(0).equals("1") ? true : false;
+ }
+
+ @Override
+ public void setEventControl(String eventFd, String controlFd,
String... args) throws IOException {
+ StringBuilder sb = new StringBuilder();
+ sb.append(eventFd);
+ sb.append(' ');
+ sb.append(controlFd);
+ for (String arg : args) {
+ sb.append(' ');
+ sb.append(arg);
+ }
+ CgroupUtils.writeFileByLine(Constants.getDir(this.dir,
CGROUP_EVENT_CONTROL), sb.toString());
+ }
+
+ public Hierarchy getHierarchy() {
+ return hierarchy;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public String getDir() {
+ return dir;
+ }
+
+ public CgroupCommon getParent() {
+ return parent;
+ }
+
+ public Set<CgroupCommon> getChildren() {
+ return children;
+ }
+
+ public boolean isRoot() {
+ return isRoot;
+ }
+
+ public Map<SubSystemType, CgroupCore> getCores() {
+ return cores;
+ }
+
+ public void delete() throws IOException {
+ this.free();
+ if (!this.isRoot) {
+ this.parent.getChildren().remove(this);
+ }
+ }
+
+ private void free() throws IOException {
+ for (CgroupCommon child : this.children) {
+ child.free();
+ }
+ if (this.isRoot) {
+ return;
+ }
+ Set<Integer> tasks = this.getTasks();
+ if (tasks != null) {
+ for (Integer task : tasks) {
+ this.parent.addTask(task);
+ }
+ }
+ CgroupUtils.deleteDir(this.dir);
+ }
+
+ private void init() {
--- End diff --
will refactor
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
