[ 
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15135596#comment-15135596
 ] 

ASF GitHub Bot commented on STORM-1336:
---------------------------------------

Github user jerrypeng commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1053#discussion_r52098040
  
    --- Diff: 
storm-core/src/jvm/org/apache/storm/container/cgroup/SubSystem.java ---
    @@ -0,0 +1,78 @@
    +/**
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.storm.container.cgroup;
    +
    +public class SubSystem {
    +
    +    private SubSystemType type;
    +
    +    private int hierarchyID;
    +
    +    private int cgroupsNum;
    +
    +    private boolean enable;
    +
    +    public SubSystem(SubSystemType type, int hierarchyID, int cgroupNum, 
boolean enable) {
    +        this.type = type;
    +        this.hierarchyID = hierarchyID;
    +        this.cgroupsNum = cgroupNum;
    +        this.enable = enable;
    +    }
    +
    +    public SubSystemType getType() {
    +        return type;
    +    }
    +
    +    public void setType(SubSystemType type) {
    +        this.type = type;
    +    }
    +
    +    public int getHierarchyID() {
    +        return hierarchyID;
    +    }
    +
    +    public void setHierarchyID(int hierarchyID) {
    +        this.hierarchyID = hierarchyID;
    +    }
    +
    +    public int getCgroupsNum() {
    +        return cgroupsNum;
    +    }
    +
    +    public void setCgroupsNum(int cgroupsNum) {
    +        this.cgroupsNum = cgroupsNum;
    +    }
    +
    +    public boolean isEnable() {
    +        return enable;
    +    }
    +
    +    public void setEnable(boolean enable) {
    +        this.enable = enable;
    +    }
    +
    +    @Override
    +    public boolean equals(Object object) {
    +        boolean ret = false;
    +        if (object != null && object instanceof SubSystem) {
    +            ret = (this.type.equals(((SubSystem)object).getType()) && 
this.hierarchyID == ((SubSystem)object).getHierarchyID());
    --- End diff --
    
    will refactor


> Evalute/Port JStorm cgroup support
> ----------------------------------
>
>                 Key: STORM-1336
>                 URL: https://issues.apache.org/jira/browse/STORM-1336
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Boyang Jerry Peng
>              Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using 
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to