[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15136121#comment-15136121
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user jerrypeng commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52111863
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -1062,9 +1072,15 @@
(add-to-classpath [stormjar])
(add-to-classpath topo-classpath))
top-gc-opts (storm-conf TOPOLOGY-WORKER-GC-CHILDOPTS)
- mem-onheap (if (and mem-onheap (> mem-onheap 0)) ;; not nil and
not zero
- (int (Math/ceil mem-onheap)) ;; round up
+ mem-onheap (if (and (.get_mem_on_heap resources) (>
(.get_mem_on_heap resources) 0)) ;; not nil and not zero
+ (int (Math/ceil (.get_mem_on_heap resources))) ;;
round up
(storm-conf WORKER-HEAP-MEMORY-MB)) ;; otherwise
use default value
+ mem-offheap (if (.get_mem_off_heap resources)
+ (int (Math/ceil (.get_mem_off_heap resources))) ;;
round up
+ 0)
+
+ cpu (int (Math/ceil (.get_cpu resources)))
--- End diff --
we actually don't need to check any of the resource configs since the
configs are validated in StormSubmitter when the topology is submitted
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
