[
https://issues.apache.org/jira/browse/STORM-1226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137468#comment-15137468
]
ASF GitHub Bot commented on STORM-1226:
---------------------------------------
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1074#discussion_r52208583
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -643,10 +650,13 @@
topology (read-storm-topology-as-nimbus storm-id blob-store)
task->component (storm-task-info topology storm-conf)]
(->> (storm-task-info topology storm-conf)
- reverse-map
+ (Utils/reverseMap)
+ clojurify-structure
(map-val sort)
- (join-maps component->executors)
- (map-val (partial apply partition-fixed))
+ ((fn [ & maps ] (Utils/joinMaps (into-array (into
[component->executors] maps)))))
+ (clojurify-structure)
+ (map-val (partial apply (fn part-fixed [a b]
(Utils/partitionFixed a b))))
+ ((fn [whatever] (log-message (pr-str "after-partition-fixed: "
whatever)) whatever))
--- End diff --
I think this debugging line should be removed.
> Port backtype.storm.util to java
> --------------------------------
>
> Key: STORM-1226
> URL: https://issues.apache.org/jira/browse/STORM-1226
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Reza Farivar
> Labels: java-migration, jstorm-merger
>
> Port backtype.storm.util from clojure to java. In as many instances as
> possible the same interface should be maintained, and calls to clojure
> functions in the rest of the code should be replaces with calls to the
> corresponding java code.
> Some similar functions can be found at
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/utils/JStormUtils.java
> Although they are not identical.
> For function callbacks we may need to evaluate adding in appropriate callback
> interfaces instead. Please try to avoid using clojure internal java classes
> unless necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
