[
https://issues.apache.org/jira/browse/STORM-1336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140363#comment-15140363
]
ASF GitHub Bot commented on STORM-1336:
---------------------------------------
Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52416971
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/core/CpusetCore.java ---
@@ -0,0 +1,209 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.container.cgroup.core;
+
+import org.apache.storm.container.cgroup.CgroupUtils;
+import org.apache.storm.container.cgroup.SubSystemType;
+
+import java.io.IOException;
+import java.util.LinkedList;
+
+public class CpusetCore implements CgroupCore {
+
+ public static final String CPUSET_CPUS = "/cpuset.cpus";
+ public static final String CPUSET_MEMS = "/cpuset.mems";
+ public static final String CPUSET_MEMORY_MIGRATE =
"/cpuset.memory_migrate";
+ public static final String CPUSET_CPU_EXCLUSIVE =
"/cpuset.cpu_exclusive";
+ public static final String CPUSET_MEM_EXCLUSIVE =
"/cpuset.mem_exclusive";
+ public static final String CPUSET_MEM_HARDWALL =
"/cpuset.mem_hardwall";
+ public static final String CPUSET_MEMORY_PRESSURE =
"/cpuset.memory_pressure";
+ public static final String CPUSET_MEMORY_PRESSURE_ENABLED =
"/cpuset.memory_pressure_enabled";
+ public static final String CPUSET_MEMORY_SPREAD_PAGE =
"/cpuset.memory_spread_page";
+ public static final String CPUSET_MEMORY_SPREAD_SLAB =
"/cpuset.memory_spread_slab";
+ public static final String CPUSET_SCHED_LOAD_BALANCE =
"/cpuset.sched_load_balance";
+ public static final String CPUSET_SCHED_RELAX_DOMAIN_LEVEL =
"/cpuset.sched_relax_domain_level";
+
+ private final String dir;
+
+ public CpusetCore(String dir) {
+ this.dir = dir;
+ }
+
+ @Override
+ public SubSystemType getType() {
+ return SubSystemType.cpuset;
+ }
+
+ public void setCpus(int[] nums) throws IOException {
+ setConfigs(nums, CPUSET_CPUS);
+ }
+
+ public int[] getCpus() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir, CPUSET_CPUS)).get(0);
+ return parseNums(output);
+ }
+
+ public void setMems(int[] nums) throws IOException {
+ setConfigs(nums, CPUSET_MEMS);
+ }
+
+ private void setConfigs(int[] nums, String config) throws IOException {
+ StringBuilder sb = new StringBuilder();
+ for (int num : nums) {
+ sb.append(num);
+ sb.append(',');
+ }
+ sb.deleteCharAt(sb.length() - 1);
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir, config),
sb.toString());
+ }
+
+ public int[] getMems() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir, CPUSET_MEMS)).get(0);
+ return parseNums(output);
+ }
+
+ public void setMemMigrate(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_MIGRATE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemMigrate() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_MIGRATE)).get(0));
+ return output > 0;
+ }
+
+ public void setCpuExclusive(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_CPU_EXCLUSIVE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isCpuExclusive() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_CPU_EXCLUSIVE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemExclusive(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_EXCLUSIVE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemExclusive() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_EXCLUSIVE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemHardwall(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_HARDWALL), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemHardwall() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEM_HARDWALL)).get(0));
+ return output > 0;
+ }
+
+ public int getMemPressure() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE)).get(0);
+ return Integer.parseInt(output);
+ }
+
+ public void setMemPressureEnabled(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE_ENABLED), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemPressureEnabled() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_PRESSURE_ENABLED)).get(0));
+ return output > 0;
+ }
+
+ public void setMemSpreadPage(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_PAGE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemSpreadPage() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_PAGE)).get(0));
+ return output > 0;
+ }
+
+ public void setMemSpreadSlab(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_SLAB), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isMemSpreadSlab() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_MEMORY_SPREAD_SLAB)).get(0));
+ return output > 0;
+ }
+
+ public void setSchedLoadBlance(boolean flag) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_LOAD_BALANCE), String.valueOf(flag ? 1 : 0));
+ }
+
+ public boolean isSchedLoadBlance() throws IOException {
+ int output =
Integer.parseInt(CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_LOAD_BALANCE)).get(0));
+ return output > 0;
+ }
+
+ public void setSchedRelaxDomainLevel(int value) throws IOException {
+ CgroupUtils.writeFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_RELAX_DOMAIN_LEVEL), String.valueOf(value));
+ }
+
+ public int getSchedRelaxDomainLevel() throws IOException {
+ String output =
CgroupUtils.readFileByLine(CgroupUtils.getDir(this.dir,
CPUSET_SCHED_RELAX_DOMAIN_LEVEL)).get(0);
+ return Integer.parseInt(output);
+ }
+
+ public static int[] parseNums(String outputStr) {
+ char[] output = outputStr.toCharArray();
+ LinkedList<Integer> numList = new LinkedList<Integer>();
+ int value = 0;
+ int start = 0;
+ boolean isHyphen = false;
+ for (char ch : output) {
--- End diff --
can this be simplified to
```
for (str in outputStr.split(","))
if (!str.contains("-"))
numList.add(Integer.valueOf(str))
else {
Integer start = Integer.valueOf(str.split("-")[0])
Integer end = Integer.valueOf(str.split("-")[1])
// Add from start to end to numList
}
```
It is based on my understanding of list format. Hope it covers the cases
> Evalute/Port JStorm cgroup support
> ----------------------------------
>
> Key: STORM-1336
> URL: https://issues.apache.org/jira/browse/STORM-1336
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Boyang Jerry Peng
> Labels: jstorm-merger
>
> Supports controlling the upper limit of CPU core usage for a worker using
> cgroups
> Sounds like a good start, will be nice to integrate it with RAS requests too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
