[ 
https://issues.apache.org/jira/browse/STORM-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140688#comment-15140688
 ] 

ASF GitHub Bot commented on STORM-1532:
---------------------------------------

GitHub user arunmahadevan opened a pull request:

    https://github.com/apache/storm/pull/1094

    [STORM-1532]: Fix readCommandLineOpts to parse JSON correctly in windows

    In Windows env, the storm.options are not url-encoded. The parsing logic 
needs to be fixed to not split in the middle of raw JSON objects.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/arunmahadevan/storm STORM-1532

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1094.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1094
    
----

----


> Fix readCommandLineOpts to parse JSON correctly
> -----------------------------------------------
>
>                 Key: STORM-1532
>                 URL: https://issues.apache.org/jira/browse/STORM-1532
>             Project: Apache Storm
>          Issue Type: Bug
>            Reporter: Arun Mahadevan
>            Assignee: Arun Mahadevan
>
> Utils.readCommandLineOpts does a split on "," so it does not correctly parse 
> values passed as json object or json arrays.
> Tested by passing 
> -c drpc.servers=[\"host1\", \"host2\"]  in storm jar command and it fails 
> with an exception,
> Exception in thread "main" java.lang.IllegalArgumentException: Field 
> DRPC_SERVERS must be an Iterable but was a class java.lang.String



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to