[ 
https://issues.apache.org/jira/browse/STORM-1245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141570#comment-15141570
 ] 

ASF GitHub Bot commented on STORM-1245:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1069#discussion_r52517486
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/acker.clj ---
    @@ -18,74 +18,24 @@
       (:import [org.apache.storm.tuple Tuple Fields])
    --- End diff --
    
    Lets just delete this file entirely.  There is not reason to play the games 
with wrapping the acker bolt and using the Container so that the acker can be 
serializable.  AckerBolt is already serializable and has the ID set properly so 
lets just delete this file.


> port backtype.storm.daemon.acker to java
> ----------------------------------------
>
>                 Key: STORM-1245
>                 URL: https://issues.apache.org/jira/browse/STORM-1245
>             Project: Apache Storm
>          Issue Type: New Feature
>            Reporter: Robert Joseph Evans
>            Assignee: Basti Liu
>              Labels: java-migration, jstorm-merger
>
> use 
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/task/acker/Acker.java
>  as a guide



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to