Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1098#discussion_r52711933
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -332,19 +333,24 @@
:assignment-id (.getAssignmentId isupervisor)
:my-hostname (Utils/hostname conf)
:curr-assignment (atom nil) ;; used for reporting used ports when
heartbeating
- :heartbeat-timer (mk-timer :kill-fn (fn [t]
- (log-error t "Error when processing event")
- (Utils/exitProcess 20 "Error when
processing an event")
- ))
- :event-timer (mk-timer :kill-fn (fn [t]
- (log-error t "Error when
processing event")
- (Utils/exitProcess 20 "Error when
processing an event")
- ))
- :blob-update-timer (mk-timer :kill-fn (defn blob-update-timer
- [t]
- (log-error t "Error when
processing event")
- (Utils/exitProcess 20 "Error
when processing a event"))
- :timer-name "blob-update-timer")
+ :heartbeat-timer (StormTimer/mkTimer nil
+ (reify StormTimer$TimerFunc
--- End diff --
This implementation of TimerFunc is repeated in many places. Does it make
sense to move it to java based implementation of TimerFunc and use everywhere?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
