[ 
https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146583#comment-15146583
 ] 

ASF GitHub Bot commented on STORM-1549:
---------------------------------------

GitHub user srdo opened a pull request:

    https://github.com/apache/storm/pull/1107

    STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector

    See https://issues.apache.org/jira/browse/STORM-1549.
    
    Other than implementing tuple timeout reset, I made a minor change to 
assert-loop in integration_test.clj so it doesn't hang on failing tests. It 
should now fail the test after 10 seconds. I hope that's okay.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/srdo/storm 1.x-branch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/1107.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1107
    
----
commit 406052cdc7138046a79104fc5c6f72212415f7f2
Author: Stig Rohde Døssing <[email protected]>
Date:   2016-02-14T01:39:42Z

    STORM-1549: Add support for resetting tuple timeout from bolts via the 
OutputCollector

----


> Add support for extending tuple tree timeout
> --------------------------------------------
>
>                 Key: STORM-1549
>                 URL: https://issues.apache.org/jira/browse/STORM-1549
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Stig Rohde Døssing
>            Assignee: Stig Rohde Døssing
>            Priority: Minor
>
> During the discussion of https://github.com/apache/storm/pull/700 the issue 
> of allowing timeout extension in case of unavailable external components 
> (such as a web service) came up.
> The current implementation makes tuples fail at a set interval, regardless of 
> whether or not replaying them is necessary. This can be irritating in 
> topologies that emit to multiple services, since one hanging service will 
> cause replays to hit all the working services as well.
> I suggest adding a resetTimeout function to IOutputCollector, which will make 
> the relevant ackers and spouts reinsert the tuple tree information in their 
> pending maps. 
> The intended usage is that a bolt can call this function on an interval if it 
> needs to delay expiration, for example if it needs to retry calling a web 
> server a few times. It may also be useful for slow topologies that want Storm 
> to detect hanging/dropped tuples faster than the max expected complete 
> latency of the topology.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to