Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1114#discussion_r53132456
--- Diff: storm-core/test/jvm/org/apache/storm/utils/TimeTest.java ---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.storm.utils;
+
+import org.junit.Test;
+import org.junit.Assert;
+
+public class TimeTest{
+
+ @Test
+ public void secsToMillisLongTest(){
+ Assert.assertEquals(Time.secsToMillisLong(0), 0);
+ Assert.assertEquals(Time.secsToMillisLong(0.002), 2);
+ Assert.assertEquals(Time.secsToMillisLong(1), 1000);
+ Assert.assertEquals(Time.secsToMillisLong(1.08), 1080);
+ Assert.assertEquals(Time.secsToMillisLong(10), 10000);
+ Assert.assertEquals(Time.secsToMillisLong(10.1), 10100);
+ }
+
+ @Test
+ public void ifNotSimulatingIsSimulatingReturnsFalse(){
+ Assert.assertFalse(Time.isSimulating());
+ }
+
+ @Test
+ public void ifSimulatingIsSimulatingReturnsTrue(){
+ Time.startSimulating();
+ Assert.assertTrue(Time.isSimulating());
+ Time.stopSimulating();
+ }
+
+ @Test
+ public void advanceTimeSimulatedTimeBy0Causes0DeltaTest(){
+ Time.startSimulating();
+ long current = Time.currentTimeMillis();
+ Time.advanceTime(0);
+ Assert.assertEquals(Time.deltaMs(current), 0);
+ Time.stopSimulating();
+ }
+
+ @Test
+ public void advanceTimeSimulatedTimeBy1000Causes1000MsDeltaTest(){
+ Time.startSimulating();
+ long current = Time.currentTimeMillis();
+ Time.advanceTime(1000);
+ Assert.assertEquals(Time.deltaMs(current), 1000);
+ Time.stopSimulating();
+ }
+
+ @Test
+ public void advanceTimeSimulatedTimeBy1500Causes1500MsDeltaTest(){
+ Time.startSimulating();
+ long current = Time.currentTimeMillis();
+ Time.advanceTime(1500);
+ Assert.assertEquals(Time.deltaMs(current), 1500);
+ Time.stopSimulating();
+ }
+
+ @Test
+ public void
advanceTimeSimulatedTimeByNegative1500CausesNegative1500MsDeltaTest(){
--- End diff --
The test names are too long. There is no need to code the parameters in the
test case name itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
