[
https://issues.apache.org/jira/browse/STORM-1522?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154652#comment-15154652
]
ASF GitHub Bot commented on STORM-1522:
---------------------------------------
Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1116#discussion_r53500680
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -146,8 +146,10 @@
(logviewer-link host (event-logs-filename topology-id port) secure?))
(defn worker-log-link [host port topology-id secure?]
- (let [fname (logs-filename topology-id port)]
- (logviewer-link host fname secure?)))
+ (if (or (empty? host) (let [port_str (str port "")] (or (empty?
port_str) (= "0" port_str))))
--- End diff --
Can we have proper indentation instead of having a single long line. Also,
Can we have if condition inside a single let binding instead of have two lets
under an if
> REST API throws invalid worker log links.
> -----------------------------------------
>
> Key: STORM-1522
> URL: https://issues.apache.org/jira/browse/STORM-1522
> Project: Apache Storm
> Issue Type: Bug
> Components: storm-core
> Reporter: Satish Duggana
> Assignee: Satish Duggana
> Fix For: 1.0.0
>
>
> Below REST API returns response which contains invalid worker log links
> http://localhost:8080/api/v1/topology/<topology-id>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
