Github user redsanket commented on a diff in the pull request:
https://github.com/apache/storm/pull/1116#discussion_r53500680
--- Diff: storm-core/src/clj/org/apache/storm/ui/core.clj ---
@@ -146,8 +146,10 @@
(logviewer-link host (event-logs-filename topology-id port) secure?))
(defn worker-log-link [host port topology-id secure?]
- (let [fname (logs-filename topology-id port)]
- (logviewer-link host fname secure?)))
+ (if (or (empty? host) (let [port_str (str port "")] (or (empty?
port_str) (= "0" port_str))))
--- End diff --
Can we have proper indentation instead of having a single long line. Also,
Can we have if condition inside a single let binding instead of have two lets
under an if
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
