[ 
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15157621#comment-15157621
 ] 

ASF GitHub Bot commented on STORM-822:
--------------------------------------

Github user knusbaum commented on the pull request:

    https://github.com/apache/storm/pull/1131#issuecomment-187366632
  
    I don't think the blacklist is going to work in general since it is 
possible in Storm to get multiple ack or fail messages for the same messageId. 
I think it would be better to empty `emittedTuples` and `failedTuples` on 
rebalance and determine if a message should be ignored based on its membership 
in those maps. 
    
    Everything else looks pretty good besides normal cleanup.


> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to 
> reduce dependencies and use long term supported kafka apis 
> --------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: STORM-822
>                 URL: https://issues.apache.org/jira/browse/STORM-822
>             Project: Apache Storm
>          Issue Type: Story
>          Components: storm-kafka
>            Reporter: Thomas Becker
>            Assignee: Hugo Louro
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to