[
https://issues.apache.org/jira/browse/STORM-1571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159098#comment-15159098
]
ASF GitHub Bot commented on STORM-1571:
---------------------------------------
Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1143#issuecomment-187766058
I agree that use System.currentTimeMillis() instead of System.nanoTime()
will improve performance, but if the code between the timing part is very fast,
say, mostly < 1ms, then we possibly won't get useful metrics using
System.currentTimeMillis.
> Improvment Kafka Spout Time Metric
> ----------------------------------
>
> Key: STORM-1571
> URL: https://issues.apache.org/jira/browse/STORM-1571
> Project: Apache Storm
> Issue Type: Improvement
> Components: storm-kafka
> Affects Versions: 0.9.3, 0.9.4, 0.9.5, 0.9.6
> Environment: Mac 10.11.1 JDK 1.8.0_40
> Reporter: darion yaphet
> Assignee: darion yaphet
> Priority: Minor
> Attachments: 0001-Improvment-Kafka-Spout-Time-Metric.patch
>
>
> Use System.currentTimeMillis() to calculation time interval is better than
> System.nanoTime()
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
