Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1069#discussion_r53898379
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/Acker.java ---
@@ -0,0 +1,127 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.daemon;
+
+import org.apache.storm.task.IBolt;
+import org.apache.storm.task.OutputCollector;
+import org.apache.storm.task.TopologyContext;
+import org.apache.storm.tuple.Tuple;
+import org.apache.storm.tuple.Values;
+import org.apache.storm.utils.RotatingMap;
+import org.apache.storm.utils.TupleUtils;
+import org.apache.storm.utils.Utils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.util.List;
+import java.util.Map;
+
+public class Acker implements IBolt {
+ private static final Logger LOG = LoggerFactory.getLogger(Acker.class);
+
+ private static final long serialVersionUID = 4430906880683183091L;
+
+ public static final String ACKER_COMPONENT_ID = "__acker";
+ public static final String ACKER_INIT_STREAM_ID = "__ack_init";
+ public static final String ACKER_ACK_STREAM_ID = "__ack_ack";
+ public static final String ACKER_FAIL_STREAM_ID = "__ack_fail";
+
+ public static final int TIMEOUT_BUCKET_NUM = 3;
+
+ private OutputCollector collector;
+ private RotatingMap<Object, AckObject> pending;
+
+ private class AckObject {
+ public long val = 0L;
--- End diff --
0 is assigned as default-value only in the update-ack call. let's say FAIL
arrives first. `cond (= 0 (:val curr)` will return false in the clojure code
because val is nil. If val was zero instead, acker would have acked a failed
message. The reason is value is checked first and failure is checked
afterwards. It is not a problem in your changes since code just returns if fail
comes before init.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
