[
https://issues.apache.org/jira/browse/STORM-1250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167068#comment-15167068
]
ASF GitHub Bot commented on STORM-1250:
---------------------------------------
Github user unsleepy22 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1150#discussion_r54078236
--- Diff:
storm-core/test/jvm/org/apache/storm/serialization/SerializationTest.java ---
@@ -0,0 +1,160 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.serialization;
+
+import clojure.lang.PersistentArrayMap;
+import clojure.lang.PersistentHashSet;
+import clojure.lang.PersistentVector;
+import clojure.lang.RT;
+import com.google.common.collect.Lists;
+import org.apache.storm.Config;
+import org.apache.storm.testing.TestSerObject;
+import org.apache.storm.utils.Utils;
+import org.junit.Assert;
+import org.junit.Test;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+import java.util.*;
+
+public class SerializationTest {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(SerializationTest.class);
+
+
+ public Map mkConf(Map extra) {
+ Map config = Utils.readDefaultConfig();
+ config.putAll(extra);
+ return config;
+ }
+
+ public byte[] serialize(List vals, Map conf) throws IOException {
+ KryoValuesSerializer serializer = new
KryoValuesSerializer(mkConf(conf));
+ return serializer.serialize(vals);
+ }
+
+ public List deserialize(byte[] bytes, Map conf) throws IOException {
+ KryoValuesDeserializer deserializer = new
KryoValuesDeserializer(mkConf(conf));
+ return deserializer.deserialize(bytes);
+ }
+
+ public List roundtrip(List vals) {
+ return roundtrip(vals, new HashMap());
+ }
+
+ public List roundtrip(List vals, Map conf) {
+ List ret = null;
+ try {
+ ret = deserialize(serialize(vals, conf), conf);
+ } catch (IOException e) {
+ LOG.error("Exception when serialize/deserialize ", e);
+ }
+ return ret;
+ }
+
+ @Test
+ public void testJavaSerialization() {
+ Object obj = new TestSerObject(1, 2);
+ List<Object> vals = Lists.newArrayList(obj);
+
+ Map<String, Object> conf = new HashMap<>();
+ conf.put(Config.TOPOLOGY_KRYO_REGISTER, new HashMap<String,
String>() {{
+ put("org.apache.storm.testing.TestSerObject", null);
+ }});
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, false);
+ try {
+ roundtrip(vals, conf);
+ Assert.fail("Expected Exception not Thrown for config: " +
conf);
+ } catch (Exception e) {
+ }
+
+ conf.clear();
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, true);
+ Assert.assertEquals(vals, roundtrip(vals, conf));
+ }
+
+ @Test
+ public void testKryoDecorator() {
+ Object obj = new TestSerObject(1, 2);
+ List<Object> vals = Lists.newArrayList(obj);
+
+ Map<String, Object> conf = new HashMap<>();
+ conf.put(Config.TOPOLOGY_FALL_BACK_ON_JAVA_SERIALIZATION, false);
+ try {
+ roundtrip(vals, conf);
+ Assert.fail("Expected Exception not Thrown for config: " +
conf);
+ } catch (Exception e) {
+ }
+
+ conf.put(Config.TOPOLOGY_KRYO_DECORATORS,
Lists.newArrayList("org.apache.storm.testing.TestKryoDecorator"));
+ Assert.assertEquals(vals, roundtrip(vals, conf));
+ }
+
+
+ public static String mkString(int size) {
+ StringBuilder sb = new StringBuilder();
+ while (size-- > 0) {
+ sb.append("a");
+ }
+ return sb.toString();
+ }
+
+ public void isRoundtrip(List vals) {
+ Assert.assertEquals(vals, roundtrip(vals));
+ }
+
+ @Test
+ public void testStringSerialization() {
+ isRoundtrip(Lists.newArrayList("a", "bb", "cbe"));
+ isRoundtrip(Lists.newArrayList(mkString(64 * 1024)));
+ isRoundtrip(Lists.newArrayList(mkString(1024 * 1024)));
+ isRoundtrip(Lists.newArrayList(mkString(1024 * 1024 * 2)));
+ }
+
+ /** when we move to java totally, we can remove this test function
entirely **/
+ @Test
+ public void testClojureSerialization() {
+ isRoundtrip(PersistentVector.create(RT.keyword(null, "a")));
--- End diff --
minor, you can extract RT.keyword to a method so we don't see so many null.
> port backtype.storm.serialization-test to java
> -----------------------------------------------
>
> Key: STORM-1250
> URL: https://issues.apache.org/jira/browse/STORM-1250
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Jark Wu
> Labels: java-migration, jstorm-merger
>
> junit test migration
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
