Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1147#discussion_r54253995
--- Diff: storm-core/src/jvm/org/apache/storm/stats/SpoutExecutorStats.java
---
@@ -0,0 +1,84 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.storm.stats;
+
+import java.util.HashMap;
+import java.util.Map;
+import org.apache.storm.metric.internal.MultiCountStatAndMetric;
+import org.apache.storm.metric.internal.MultiLatencyStatAndMetric;
+
+@SuppressWarnings("unchecked")
+public class SpoutExecutorStats extends CommonStats {
+
+ public static final String ACKED = "acked";
+ public static final String FAILED = "failed";
+ public static final String COMPLETE_LATENCIES = "complete-latencies";
+
+ public static final String[] SPOUT_FIELDS = {ACKED, FAILED,
COMPLETE_LATENCIES};
+
+ public SpoutExecutorStats() {
+ super();
+ this.put(ACKED, new MultiCountStatAndMetric(NUM_STAT_BUCKETS));
+ this.put(FAILED, new MultiCountStatAndMetric(NUM_STAT_BUCKETS));
+ this.put(COMPLETE_LATENCIES, new
MultiLatencyStatAndMetric(NUM_STAT_BUCKETS));
+ }
+
+ public MultiCountStatAndMetric getAcked() {
+ return (MultiCountStatAndMetric) this.get(ACKED);
+ }
+
+ public MultiCountStatAndMetric getFailed() {
+ return (MultiCountStatAndMetric) this.get(FAILED);
+ }
+
+ public MultiLatencyStatAndMetric getCompleteLatencies() {
+ return (MultiLatencyStatAndMetric) this.get(COMPLETE_LATENCIES);
+ }
+
+ public void spoutAckedTuple(String stream, long latencyMs) {
+ this.getAcked().incBy(stream, this.rate);
+ this.getCompleteLatencies().record(stream, latencyMs);
+ }
+
+ public void spoutFailedTuple(String stream, long latencyMs) {
+ this.getFailed().incBy(stream, this.rate);
+ }
+
+ public Map renderStats() {
+ cleanupStats();
+ Map ret = new HashMap();
+ ret.putAll(valueStats(CommonStats.COMMON_FIELDS));
+ ret.putAll(valueStats(SpoutExecutorStats.SPOUT_FIELDS));
+ StatsUtil.putRawKV(ret, StatsUtil.TYPE, StatsUtil.KW_SPOUT);
+
+ return ret;
+ }
+
+ public void cleanupStats() {
+ super.cleanupStats();
+ for (String field : SpoutExecutorStats.SPOUT_FIELDS) {
+ cleanupStat(this.get(field));
+ }
+ }
+
+ public static SpoutExecutorStats mkSpoutStats(int rate) {
--- End diff --
Can we just have the constructor have the rate, and remove this entirely?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
