[
https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172439#comment-15172439
]
ASF GitHub Bot commented on STORM-822:
--------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1131#issuecomment-190345957
For the most part things look good. My biggest concern is around catching
Exception and ignoring it when we commit offsets.
I am also a little concerned about having auto-commit be the default, as it
violates some of storms guarantees. I would prefer it to honor storms
guarantees by default.
> As a storm developer I’d like to use the new kafka consumer API (0.8.3) to
> reduce dependencies and use long term supported kafka apis
> --------------------------------------------------------------------------------------------------------------------------------------
>
> Key: STORM-822
> URL: https://issues.apache.org/jira/browse/STORM-822
> Project: Apache Storm
> Issue Type: Story
> Components: storm-kafka
> Reporter: Thomas Becker
> Assignee: Hugo Louro
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
