[ https://issues.apache.org/jira/browse/STORM-1228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15172499#comment-15172499 ]
ASF GitHub Bot commented on STORM-1228: --------------------------------------- Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1160#discussion_r54468012 --- Diff: storm-core/test/jvm/org/apache/storm/tuple/FieldsTest.java --- @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.storm.tuple; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; + +import org.junit.Assert; +import org.junit.Test; + +public class FieldsTest { + + @Test + public void fieldsConstructorDoesNotThrowWithValidArgsTest() { + Assert.assertEquals(new Fields("foo", "bar").size(), 2); + Assert.assertEquals(new Fields(new String[] {"foo", "bar"}).size(), 2); + } + + @Test(expected = IllegalArgumentException.class) + public void duplicateFieldsNotAllowedWhenConstructingWithVarArgsTest() { + new Fields("foo", "bar", "foo"); + } + + @Test(expected = IllegalArgumentException.class) + public void duplicateFieldsNotAllowedTestWhenConstructingFromListTest() { + new Fields(new String[] {"foo", "bar", "foo"}); + } + + private Fields getFields() { + return new Fields("foo", "bar"); --- End diff -- There are a lot of places where I would prefer to create the Fields instance once and then manipulate it, instead of creating a new one each time. Also I find it cleaner to see the class being instantiated right by where they are tested. > port backtype.storm.fields-test to java > ---------------------------------------- > > Key: STORM-1228 > URL: https://issues.apache.org/jira/browse/STORM-1228 > Project: Apache Storm > Issue Type: New Feature > Components: storm-core > Reporter: Robert Joseph Evans > Assignee: Alessandro Bellina > Labels: java-migration, jstorm-merger > > This is a test that should be simple to move to JUnit -- This message was sent by Atlassian JIRA (v6.3.4#6332)