Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/1161#issuecomment-190742680
  
    The changes I see look fine to me I am +1 for merging them in.  If we are 
going to go with this patch I would like to see the logs dir deleted as part 
`mvn clean` and I would like to see it added to `.gitignore` so we don't add 
log files by accident.
    
    I personally think that a final solution should include changing how we do 
logging when in local mode.  I would disable the dynamic log configuration for 
workers when in local mode, and I would disable the event logger configuration 
when in local mode.  I have seen errors when I try to run in local mode and the 
permissions for log files in `storm.home` or `storm.log.dir` are not quite set 
properly.  If I am running in local mode I should not be writing anything to 
`storm.home`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to