Github user abhishekagarwal87 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1174#discussion_r54685209
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/Acker.java ---
@@ -100,6 +101,8 @@ public void execute(Tuple input) {
}
curr.failed = true;
pending.put(id, curr);
+ } else if(ACKER_RESET_TIMEOUT_STREAM_ID.equals(streamId)) {
--- End diff --
This introduces a NPE scenario because earlier in all the if blocks, if
curr was null, it was getting initialized. Now curr.spoutTask will throw NPE if
reset timeout comes before init or after init times out. This can be avoided by
adding below just before `pending.put(id, curr)`
```
if (curr == null) {
curr = new AckObject();
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
