Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54771740 --- Diff: pom.xml --- @@ -836,14 +839,39 @@ <scope>test</scope> </dependency> <dependency> - <groupId>org.apache.calcite</groupId> - <artifactId>calcite-core</artifactId> - <version>${calcite.version}</version> + <groupId>org.apache.calcite</groupId> + <artifactId>calcite-core</artifactId> + <version>${calcite.version}</version> + </dependency> + <dependency> + <groupId>com.fasterxml.jackson.core</groupId> + <artifactId>jackson-databind</artifactId> + <version>${jackson.version}</version> + </dependency> + <dependency> + <groupId>org.apache.kafka</groupId> + <artifactId>${kafka.artifact.id}</artifactId> + <version>${kafka.version}</version> + <exclusions> + <exclusion> + <groupId>org.apache.zookeeper</groupId> + <artifactId>zookeeper</artifactId> + </exclusion> + <exclusion> + <groupId>log4j</groupId> + <artifactId>log4j</artifactId> + </exclusion> + <exclusion> + <groupId>org.slf4j</groupId> + <artifactId>slf4j-log4j12</artifactId> + </exclusion> + </exclusions> </dependency> <dependency> - <groupId>com.fasterxml.jackson.core</groupId> - <artifactId>jackson-databind</artifactId> - <version>${jackson.version}</version> + <groupId>org.apache.kafka</groupId> + <artifactId>kafka-clients</artifactId> + <version>${kafka.version}</version> + <scope>provided</scope> --- End diff -- Actually I looked a bit more at this and I don't think we want kafka-clients or kafka itself to be marked as provided. The `provided` scope tells the shade plugin or the assembly plugin when it is creating the uber topology jar to not include this dependency in the uber jar, because it will already be on the classpath. If we do this for the kafka libraries any topology pom.xml will either have to explicitly include their own version of kafka that is not `provided` or the topology jar will just not run. Looking at storm-starter because of this it does not have kafka in the uber jar so running any of the kafka examples will fail.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---