[
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179542#comment-15179542
]
ASF GitHub Bot commented on STORM-1269:
---------------------------------------
GitHub user bastiliu opened a pull request:
https://github.com/apache/storm/pull/1185
[STORM-1269] port backtype.storm.daemon.common to java
1. Following clojure defined records in common, "Assignment, StormBase,
SupervisorInfo, ExecutorStats", were not migrated here. There are corresponding
classes of Thrift. So, we can just use the thrift class in the dependency
modules after each module's migration.
2. worker-context was not migrated. There is much more worker to convert
the worker data between java and clojure now. But it is easy to do this after
the worker data is migrated to java. So I recommend to leave the mirgation of
worker context as a part of worker module.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bastiliu/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1185
----
commit c7241a67c23899ebb3d6c25cdccde758efb7a0ad
Author: basti.lj <[email protected]>
Date: 2016-03-04T07:16:59Z
[STORM-1269] port backtype.storm.daemon.common to java
commit 0726c116ebd2ef27b5225027bdf3008e6156018d
Author: basti.lj <[email protected]>
Date: 2016-03-04T07:18:28Z
Merge remote-tracking branch 'upstream/master'
----
> port backtype.storm.daemon.common to java
> -----------------------------------------
>
> Key: STORM-1269
> URL: https://issues.apache.org/jira/browse/STORM-1269
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Basti Liu
> Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
> is similar but not exactly the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
