[ 
https://issues.apache.org/jira/browse/STORM-1269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15183658#comment-15183658
 ] 

ASF GitHub Bot commented on STORM-1269:
---------------------------------------

Github user revans2 commented on a diff in the pull request:

    https://github.com/apache/storm/pull/1185#discussion_r55268410
  
    --- Diff: storm-core/src/clj/org/apache/storm/daemon/common.clj ---
    @@ -408,19 +69,3 @@
                               (:default-shared-resources worker)
                               (:user-shared-resources worker)
                               ))
    --- End diff --
    
    If we are leaving some methods in clojure, could you file a follow on JIRA 
to remove the file once we have the other code ported over to java?


> port backtype.storm.daemon.common to java
> -----------------------------------------
>
>                 Key: STORM-1269
>                 URL: https://issues.apache.org/jira/browse/STORM-1269
>             Project: Apache Storm
>          Issue Type: New Feature
>          Components: storm-core
>            Reporter: Robert Joseph Evans
>            Assignee: Basti Liu
>              Labels: java-migration, jstorm-merger
>
> Common utils shared by the daemons (Some things should just use the Thrift 
> object)
> https://github.com/apache/storm/blob/jstorm-import/jstorm-core/src/main/java/com/alibaba/jstorm/cluster/Common.java
>  is similar but not exactly the same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to