Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1185#issuecomment-193490519
For the most part things look really good. Just a lots of null checks that
were not in the original code. In these cases where we are validating the
structure of the topology I really would prefer to see the code blow up with an
NPE in those cases instead of silently skip over them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
