[ https://issues.apache.org/jira/browse/STORM-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184372#comment-15184372 ]
ASF GitHub Bot commented on STORM-1604: --------------------------------------- Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1188#discussion_r55314671 --- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj --- @@ -1334,7 +1334,7 @@ (.unset_reset_log_level_timeout_epoch log-config)))) (defmethod blob-sync :distributed [conf nimbus] - (if (not (is-leader nimbus :throw-exception false)) + (if (not (is-leader nimbus :throw-exception false --- End diff -- Looks like a missing parenthesis > Delayed transition should handle NotALeaderException > ---------------------------------------------------- > > Key: STORM-1604 > URL: https://issues.apache.org/jira/browse/STORM-1604 > Project: Apache Storm > Issue Type: Bug > Components: storm-core > Affects Versions: 1.0.0 > Reporter: Parth Brahmbhatt > Assignee: Parth Brahmbhatt > Fix For: 1.0.0 > > > Currently if an action(kill, rebalance) is scheduled with delay, nimbus > stores the state in zookeeper and then schedules a delayed event to do final > transition. If during this wait time, leader nimbus loses the leadership, > when the delayed operation is executed it receives a NotALeaderException > which it does not handle causing the nimbus to die. We should catch the > exception and ignore it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)