Github user unsleepy22 commented on the pull request:
https://github.com/apache/storm/pull/1147#issuecomment-193779382
@revans2 I've changed according to your opinion, still, the code in
StatsUtil might be quite rough and clojure-way, I just want to make sure it's
the right move, hope you can take a quick look.
My changes are:
1. changed executor heartbeat structure to java HashMap instead of clojure
map (and yes there's still a Map anyway)
2. moved update-heartbeat-cache method into StatsUtil.java, because of the
change to clojure structure to HashMap, they should be moved back when
translating nimbus.clj, I added TODO in methods.
3. because the HashMap structure is quite mixed, e.g., it may store "rate"
of stats which is a double, and store "emitted" which is a HashMap, so in many
methods, I used Map<String, Object>.
4. for structures like "executor->host+port", I still used the original
clojure structure because I think they might be used somewhere else, I only
want to change stats related with this PR
BTW. about your test last time, it's actually a bug of my code, I fixed
this, sorry for the confusion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
