[
https://issues.apache.org/jira/browse/STORM-1233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185049#comment-15185049
]
ASF GitHub Bot commented on STORM-1233:
---------------------------------------
GitHub user abellina reopened a pull request:
https://github.com/apache/storm/pull/1191
STORM-1233: Port AuthUtilsTest to java
I did a little bit of refactoring in AuthUtils:
- Using Hex.encodeHexString in makeDigestPayload instead of StringBuilder
and String.format
- Factored out the reflective class instantiations as a generic functions.
- Added a null check in updateSubject
I am also using JUnit TemporaryFolder to create temp folders which should
be deleted after the test runs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/abellina/storm
STORM-1233_port_AuthUtils_test_to_java
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1191.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1191
----
commit b795bd7e47e79f1e6b063db543b6d8fbfd3620f3
Author: Alessandro Bellina <[email protected]>
Date: 2016-02-29T13:49:07Z
STORM-1233: Port AuthUtilsTest to java
commit 087bf71cc1c15dac454ec729401fabfec2df9a5e
Author: Alessandro Bellina <[email protected]>
Date: 2016-03-08T02:59:55Z
STORM-1233: use Utils.newInstance and port correct logic for
test-returns-first-value-for-valid-key
commit fd02a09a75abb8afaeca8d5b6606e49051288c34
Author: Alessandro Bellina <[email protected]>
Date: 2016-03-08T14:04:38Z
STORM-1233: update exception wording
----
> port backtype.storm.security.auth.AuthUtils-test to java
> --------------------------------------------------------
>
> Key: STORM-1233
> URL: https://issues.apache.org/jira/browse/STORM-1233
> Project: Apache Storm
> Issue Type: New Feature
> Reporter: Robert Joseph Evans
> Assignee: Alessandro Bellina
> Labels: java-migration, jstorm-merger
>
> Just a test moving to junit
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
