[
https://issues.apache.org/jira/browse/STORM-1252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15185137#comment-15185137
]
ASF GitHub Bot commented on STORM-1252:
---------------------------------------
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1147#issuecomment-193839237
@unsleepy22 It looks a lot better. I don't care as much about the exact
API. we can change that in the future the important part is removing the
dependency on clojure. I have one minor issue, but overall it looks good and I
am +1 for merging it in.
StatsUtils.java 2045-2046: in weightAvgAndSum
The reason for having the productOr0 function is because the inputs could
be null, and if they were null we didn't want to blow up with an NPE. The
current code will throw an NPE. it should probably look more like.
```
ret += productOr0(entry.getValue(), id2num.get(k));
```
I plan to do a bit of testing myself, but great work.
> port backtype.storm.stats to java
> ---------------------------------
>
> Key: STORM-1252
> URL: https://issues.apache.org/jira/browse/STORM-1252
> Project: Apache Storm
> Issue Type: New Feature
> Components: storm-core
> Reporter: Robert Joseph Evans
> Assignee: Cody
> Labels: java-migration, jstorm-merger
>
> clojure methods for getting/setting built-in statistics. Mostly wrappers
> around some java classes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
